bundle: Surface configured rule notices#1827
Merged
charlieegan3 merged 2 commits intoopen-policy-agent:mainfrom Jan 13, 2026
Merged
bundle: Surface configured rule notices#1827charlieegan3 merged 2 commits intoopen-policy-agent:mainfrom
charlieegan3 merged 2 commits intoopen-policy-agent:mainfrom
Conversation
anderseknert
approved these changes
Jan 13, 2026
Member
anderseknert
left a comment
anderseknert
left a comment
There was a problem hiding this comment.
LGTM! Did you check to see if this had any noticeable impact on the benchmarks?
Contributor
Author
|
The numbers appear to be pretty comparable on consecutive runs 👍 |
If a rule is configred, and set to non-ignore level, then we should show the notices from that rule if it is not run to aid users. Fixes open-policy-agent#1795 Signed-off-by: Charlie Egan <charlie_egan@apple.com>
anderseknert
force-pushed
the
surface-configured-rule-notices
branch
from
91b1d7f to
d624ffc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a rule is configred, and set to non-ignore level, then we should show the notices from that rule if it is not run to aid users.
Fixes #1795